Skip to content

[Cato Networks] Replace try/has with is_error#20051

Open
sharad-elastic wants to merge 2 commits into
elastic:mainfrom
sharad-elastic:cato_networks-audit-timestamp-guard-followup
Open

[Cato Networks] Replace try/has with is_error#20051
sharad-elastic wants to merge 2 commits into
elastic:mainfrom
sharad-elastic:cato_networks-audit-timestamp-guard-followup

Conversation

@sharad-elastic

@sharad-elastic sharad-elastic commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Type of change

  • Enhancement

Proposed commit message

Use is_error inplace of try/has for last_timestamp

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

To test the cato networks package:

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/cato_networks directory.
  • Run the following command to run tests.

elastic-package test

Run asset tests for the package
2026/07/09 10:33:45  INFO elastic-package v0.125.1 version-hash 111636ab (build time: 2026-07-03T17:56:06+05:30)
2026/07/09 10:33:45  INFO elastic-stack: 8.19.0
--- Test results for package: cato_networks - START ---
╭───────────────┬─────────────┬───────────┬────────────────────────────────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE       │ DATA STREAM │ TEST TYPE │ TEST NAME                                                              │ RESULT │ TIME ELAPSED │
├───────────────┼─────────────┼───────────┼────────────────────────────────────────────────────────────────────────┼────────┼──────────────┤
│ cato_networks │             │ asset     │ dashboard cato_networks-95cbb672-baae-4508-b188-24a51b4d36da is loaded │ PASS   │      1.046µs │
│ cato_networks │             │ asset     │ dashboard cato_networks-9d363f59-caa0-4b84-af82-dd85d789a7dd is loaded │ PASS   │        260ns │
│ cato_networks │             │ asset     │ dashboard cato_networks-b4c8e2f1-3d5a-4f7b-9c2e-1a6d8e3f5b7c is loaded │ PASS   │        172ns │
│ cato_networks │             │ asset     │ dashboard cato_networks-f7a3c9d2-6e1b-4a8f-bc4d-9e2f5a8c1d6b is loaded │ PASS   │        196ns │
│ cato_networks │ audit       │ asset     │ index_template logs-cato_networks.audit is loaded                      │ PASS   │        201ns │
│ cato_networks │ audit       │ asset     │ ingest_pipeline logs-cato_networks.audit-0.1.1 is loaded               │ PASS   │        179ns │
│ cato_networks │ event       │ asset     │ index_template logs-cato_networks.event is loaded                      │ PASS   │        148ns │
│ cato_networks │ event       │ asset     │ ingest_pipeline logs-cato_networks.event-0.1.1 is loaded               │ PASS   │        155ns │
╰───────────────┴─────────────┴───────────┴────────────────────────────────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: cato_networks - END   ---
Done
Run pipeline tests for the package
2026/07/09 10:33:49  INFO elastic-package v0.125.1 version-hash 111636ab (build time: 2026-07-03T17:56:06+05:30)
2026/07/09 10:33:49  INFO elastic-stack: 8.19.0
--- Test results for package: cato_networks - START ---
╭───────────────┬─────────────┬───────────┬───────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE       │ DATA STREAM │ TEST TYPE │ TEST NAME                                 │ RESULT │ TIME ELAPSED │
├───────────────┼─────────────┼───────────┼───────────────────────────────────────────┼────────┼──────────────┤
│ cato_networks │ audit       │ pipeline  │ (ingest pipeline warnings test-audit.log) │ PASS   │ 240.991776ms │
│ cato_networks │ audit       │ pipeline  │ test-audit.log                            │ PASS   │ 281.315433ms │
│ cato_networks │ event       │ pipeline  │ (ingest pipeline warnings test-event.log) │ PASS   │ 249.288462ms │
│ cato_networks │ event       │ pipeline  │ test-event.log                            │ PASS   │  235.38954ms │
╰───────────────┴─────────────┴───────────┴───────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: cato_networks - END   ---
Done
Run policy tests for the package
2026/07/09 10:33:50  INFO elastic-package v0.125.1 version-hash 111636ab (build time: 2026-07-03T17:56:06+05:30)
2026/07/09 10:33:50  INFO elastic-stack: 8.19.0
--- Test results for package: cato_networks - START ---
No test results
--- Test results for package: cato_networks - END   ---
Done
Run script tests for the package
PKG cato_networks
[no test files]
--- Test results for package: cato_networks - START ---
No test results
--- Test results for package: cato_networks - END   ---
Done
Run static tests for the package
2026/07/09 10:33:50  INFO elastic-package v0.125.1 version-hash 111636ab (build time: 2026-07-03T17:56:06+05:30)
--- Test results for package: cato_networks - START ---
╭───────────────┬─────────────┬───────────┬──────────────────────────┬────────┬──────────────╮
│ PACKAGE       │ DATA STREAM │ TEST TYPE │ TEST NAME                │ RESULT │ TIME ELAPSED │
├───────────────┼─────────────┼───────────┼──────────────────────────┼────────┼──────────────┤
│ cato_networks │ audit       │ static    │ Verify sample_event.json │ PASS   │  111.25522ms │
│ cato_networks │ event       │ static    │ Verify sample_event.json │ PASS   │ 121.272605ms │
╰───────────────┴─────────────┴───────────┴──────────────────────────┴────────┴──────────────╯
--- Test results for package: cato_networks - END   ---
Done
Run system tests for the package
2026/07/09 10:33:51  INFO elastic-package v0.125.1 version-hash 111636ab (build time: 2026-07-03T17:56:06+05:30)
2026/07/09 10:33:51  INFO elastic-stack: 8.19.0
2026/07/09 10:33:51  INFO Installing package...
2026/07/09 10:34:03  INFO Running test for data_stream "audit" with configuration 'default'
2026/07/09 10:34:12  INFO Setting up independent Elastic Agent...
2026/07/09 10:34:22  INFO Setting up service...
2026/07/09 10:35:03  INFO Validating test case...
2026/07/09 10:35:04  INFO Tearing down service...
2026/07/09 10:35:05  INFO Write container logs to file: /root/integrations/build/container-logs/cato_networks-1783573505220468833.log
2026/07/09 10:35:07  INFO Tearing down agent...
2026/07/09 10:35:07  INFO Write container logs to file: /root/integrations/build/container-logs/elastic-agent-1783573507644954595.log
2026/07/09 10:35:15  INFO Running test for data_stream "event" with configuration 'default'
2026/07/09 10:35:24  INFO Setting up independent Elastic Agent...
2026/07/09 10:37:02  INFO Setting up service...
2026/07/09 10:37:50  INFO Validating test case...
2026/07/09 10:37:51  INFO Tearing down service...
2026/07/09 10:37:52  INFO Write container logs to file: /root/integrations/build/container-logs/cato_networks-1783573672223416863.log
2026/07/09 10:37:54  INFO Tearing down agent...
2026/07/09 10:37:54  INFO Write container logs to file: /root/integrations/build/container-logs/elastic-agent-1783573674678950024.log
2026/07/09 10:38:02  INFO Uninstalling package...
--- Test results for package: cato_networks - START ---
╭───────────────┬─────────────┬───────────┬───────────┬────────┬─────────────────╮
│ PACKAGE       │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │    TIME ELAPSED │
├───────────────┼─────────────┼───────────┼───────────┼────────┼─────────────────┤
│ cato_networks │ audit       │ system    │ default   │ PASS   │  1m1.214973462s │
│ cato_networks │ event       │ system    │ default   │ PASS   │ 2m36.067814202s │
╰───────────────┴─────────────┴───────────┴───────────┴────────┴─────────────────╯
--- Test results for package: cato_networks - END   ---
Done

Resolves #19307 (comment)

@sharad-elastic sharad-elastic requested a review from a team as a code owner July 9, 2026 05:15
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!

The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

efd6
efd6 reviewed Jul 9, 2026
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit only, then LGTM

Comment thread packages/cato_networks/changelog.yml Outdated
changes:
- description: Simplify the audit `last_timestamp` parse guard to use `is_error` instead of `try`/`has`.
type: enhancement
link: https://github.com/elastic/integrations/pull/1

@efd6 efd6 Jul 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
link: https://github.com/elastic/integrations/pull/1
link: https://github.com/elastic/integrations/pull/20051

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Jul 9, 2026

Copy link
Copy Markdown

💚 Build Succeeded

History

@sharad-elastic sharad-elastic requested a review from efd6 July 9, 2026 05:55
@andrewkroh andrewkroh added Integration:cato_networks Cato Networks Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels Jul 9, 2026
@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Jul 9, 2026

Copy link
Copy Markdown

Pinging @elastic/integration-experience (Team:Integration-Experience)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Integration:cato_networks Cato Networks Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sharad-elastic @efd6 @andrewkroh